Repository navigation
feat(v2): add Private PKI product names that set ProductFamily and ProductVariant - #54
Open
spbsoluble wants to merge 1 commit into
Open
spbsoluble wants to merge 1 commit into
spbsoluble wants to merge 1 commit into
Conversation
…oductVariant GetProductIds() advertised SSL/TLS names only, so a Private PKI template had to pick an SSL name (for example DV SSL) and set ProductFamily=private-pki plus ProductVariant. Add "Private PKI Intranet SSL" and "Private PKI IGTF Host": selecting one defaults ProductFamily to private-pki and ProductVariant to intranet-ssl / igtf-host. A ProductFamily or ProductVariant that contradicts the product is rejected at template save and at enrollment, before any CA call. SSL products paired with ProductFamily=private-pki keep working. Enroll() required a product code on V2 too; that check is now V1-only (V2 needs no code, and the new names have no V1 default). The ProductFamily/ProductVariant annotations no longer declare "ssl"/"dv" defaults, since the plugin derives both from the product. Also corrects the GetProductIds() comment, which described numeric codes as required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The plugin advertised SSL/TLS product names only, so a Private PKI template had to pick an SSL name (for example
DV SSL) and setProductFamily=private-pkiandProductVariantby hand. This adds two Private PKI product names that set both for you.Features
Private PKI Intranet SSLandPrivate PKI IGTF HostinGetProductIds(),Constants.Productsandintegration-manifest.json.ProductFamilytoprivate-pkiandProductVarianttointranet-sslorigtf-host(EnrollmentParams), so the order goes to the Private PKI endpoint with no extra parameters.ProductFamilyorProductVariantthat contradicts the product is rejected when the template is saved and at enrollment, before any CA call.ProductFamily=private-pkikeep working.Fixes
Enroll()required a product code on V2 too (it threw "Template parameter 'ProfileId' is required"). The check is now V1-only, asValidateProductInfoalready was: V2 needs no code, and the new products have no V1 default code. On V1 they still needProductCode.ProductFamilyandProductVarianttemplate annotations no longer declaressl/dvdefaults, since the plugin derives both from the product.GetProductIds()comment no longer says a numericProductCodeis required.Testing
private-pkifamily fails fast with no CA call; save-time validation rejectsProductFamily=ssland accepts no parameters;EnrollmentParamsfamily/variant defaults; V1 Private PKI name withoutProductCodethrows.GetProductIdscount (10 → 12); the sync type-ID round-trip test covers SSL products only (Private PKI has no known catalogproductTypeID).DcvSupport=trueandfalse: 0 warnings, 0 errors.Other
docsource/configuration.md,README.mdand the manifest descriptions forProductCode,ProductFamilyandProductVariant; CHANGELOG entry under 2.0.0.